Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links and search in navbar don't work when using dark mode #47

Closed
saewitz opened this issue Nov 7, 2022 · 5 comments · Fixed by #99
Closed

Links and search in navbar don't work when using dark mode #47

saewitz opened this issue Nov 7, 2022 · 5 comments · Fixed by #99
Labels
bug Something not working the way it's supposed to

Comments

@saewitz
Copy link
Member

saewitz commented Nov 7, 2022

No description provided.

@tybug
Copy link
Contributor

tybug commented Nov 9, 2022

due to the z-index of our star background fill. Going to be a tricky one as we want it to be above .fixed-top (z-index 1030) but below .nav-item (z-index 1 in a separate stacking context due to the bootstrap-inserted flexbox). I don't see any easy way to achieve this due to the different stacking contexts.

@saewitz
Copy link
Member Author

saewitz commented Nov 9, 2022

did it work before with web.py? if so what about the change broke it?

@nsandler1 nsandler1 added the bug Something not working the way it's supposed to label Jan 12, 2023
@kandasamyc
Copy link
Contributor

Ok, I've got a bit of sketchy fix for this: I changed the canvas z-index to 1000, and then set the color of the navbar to transparent. This works perfectly on desktop, although on mobile, the dropdown menu now has a completely black background since the the canvas doesn't extend there.
image
image

@tybug
Copy link
Contributor

tybug commented Mar 4, 2023

I think we can live with the dropdown not having stars in it. I imagine that would be pretty tricky to get to work correctly.

Will have to see the code but this approach seems ok to me, as long as it doesn't require any changes to the normal (lightmode) css. I'm ok with sketchy css for the rarely-used darkmode, but not for the standard styling.

@kandasamyc
Copy link
Contributor

I'll make the PR now, really the only sketchy part has to do with some manual adjust of the dropdown using negative paddings to account for the now transparent parent navbar padding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something not working the way it's supposed to
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants