-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links and search in navbar don't work when using dark mode #47
Comments
due to the z-index of our star background fill. Going to be a tricky one as we want it to be above |
did it work before with web.py? if so what about the change broke it? |
I think we can live with the dropdown not having stars in it. I imagine that would be pretty tricky to get to work correctly. Will have to see the code but this approach seems ok to me, as long as it doesn't require any changes to the normal (lightmode) css. I'm ok with sketchy css for the rarely-used darkmode, but not for the standard styling. |
I'll make the PR now, really the only sketchy part has to do with some manual adjust of the dropdown using negative paddings to account for the now transparent parent navbar padding. |
No description provided.
The text was updated successfully, but these errors were encountered: