Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features/unmarshal_unique: Maps with string-keys #147

Closed
coxley opened this issue Nov 19, 2024 · 0 comments · Fixed by #148
Closed

features/unmarshal_unique: Maps with string-keys #147

coxley opened this issue Nov 19, 2024 · 0 comments · Fixed by #148

Comments

@coxley
Copy link
Contributor

coxley commented Nov 19, 2024

Summary

Hey folks! I've been wanting to start using #140 and while we have some good candidates for it, one of the biggest benefits on my side would be to intern string keys inside some maps.

Any idea how tough it would be to extend to that use-case? Any gotchas come to mind?

I'm not opposed to implementing it if not — but don't care either way. :)

Example Proto

message Foo {
  string identifier = 1;
  // A bunch of tags for some entity, where there are loads of common keys across
  // 100k of messages being processed at the same time
  map<string, AttributeValue> attributes = 2;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant