Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate re-enabling mlir-doc target #940

Open
rolfmorel opened this issue Jun 24, 2024 · 3 comments
Open

Investigate re-enabling mlir-doc target #940

rolfmorel opened this issue Jun 24, 2024 · 3 comments
Labels
low-priority Things that go in the back burner

Comments

@rolfmorel
Copy link
Contributor

rolfmorel commented Jun 24, 2024

#939 removed the lines of the README regarding being able to build TableGen-derived documentation. The issue is that the mlir-doc target is broken at the moment.

We should investigate the issue (a CMakelists.txt issue?), fix it, and add building this target to the CI. When that's done, we can add back the README lines on generating the documentation.

@rolfmorel rolfmorel added the low-priority Things that go in the back burner label Jun 24, 2024
@adam-smnk
Copy link
Collaborator

This probably needs CheckOps.td to be split into a separate dialect TD file.
Good opportunity to also do some minor cleanup.

@adam-smnk
Copy link
Collaborator

@rengolin Should we add docs to CI?
Otherwise, IMO no point in maintaining it at all as we don't really use them.

@rengolin
Copy link
Contributor

The question here is if we want to maintain this at all. If the answer is yes, then we must do it right and add it to CI. Otherwise we just close this issue and don't think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority Things that go in the back burner
Projects
None yet
Development

No branches or pull requests

3 participants