[Registration Notification] The plugin is mistakenly checking if it's active using the main context settings

[jonasraoni]

Describe the bug
The plugin is checking if it's active using the "main context", but it's currently not a site-wide plugin.

What application are you using?
OJS 3.3

Additional information
$this->getEnabled($mainContextId)

[NateWr]

I'm not certain, but I think the $mainContextId is a deprecated thing from OJS 2, where there was a multi-tier context system of some kind. The variable that is passed in here shouldn't reflect the "current context" as you would expect. I could be wrong, thoughh.

[asmecher]

I'm not certain, but I think the $mainContextId is...

The reasoning for this is documented in LazyLoadPlugin::getEnabled:

	 * @param $contextId integer To identify if the plugin is enabled
	 *  we need a context. This context is usually taken from the
	 *  request but sometimes there is no context in the request
	 *  (e.g. when executing CLI commands). Then the main context
	 *  can be given as an explicit ID.

[ctgraham]

Interestingly, this makes a big difference when the plugin is a sitewide plugin. Currently, without a specific context passed in, a sitewide plugin will presume that getEnabled() wants to operate on CONTEXT_SITE.

pkp-lib/classes/plugins/LazyLoadPlugin.inc.php

Lines 69 to 78 in ee06636

	public function getEnabled($contextId = null)
	{
	if ($contextId == null) {
	$contextId = $this->getCurrentContextId();
	if ($this->isSitePlugin()) {
	$contextId = 0;
	}
	}
	return $this->getSetting($contextId, 'enabled');
	}

But generally (without addtional footwork in the plugin code) enabling a sitewide plugin will act on the specific context, leading to a bug like: pkp/shibboleth#3

The ability of a sitewide plugin to act specifically within a context is often desirable, so this leads to some crazy plugin code:
https://github.com/pkp/shibboleth/blob/3e59e58dcb09ed10e762c073365928bcb9dc05f3/ShibbolethAuthPlugin.inc.php#L27-L43

https://github.com/pkp/shibboleth/blob/3e59e58dcb09ed10e762c073365928bcb9dc05f3/ShibbolethAuthPlugin.inc.php#L178-L205

[asmecher]

@ctgraham, do you think this might be the same issue as #6137?

[ctgraham]

I think it is certainly a fork of the endless morass of #1923 .