Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Switch to app router of next.js #164

Closed
Your-Ehsan opened this issue Oct 14, 2023 · 7 comments
Closed

Proposal: Switch to app router of next.js #164

Your-Ehsan opened this issue Oct 14, 2023 · 7 comments
Labels
enhancement New feature or request hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted

Comments

@Your-Ehsan
Copy link

Your-Ehsan commented Oct 14, 2023

Proposal: I think that would be great if we switch the routing of our review app to the app router of next.js because it is easy to maintain and work with.

Currently it is working on page router.

I realized that the new comers who are at the learning phase in next.js are comfortable with nextjs's app router because it is now recommended by the next.js's community also.

your thoughts & suggestions are appreciate able

here's the nextjs's official guide
https://nextjs.org/docs/pages/building-your-application/upgrading/app-router-migration

@Your-Ehsan Your-Ehsan changed the title Switch to app router of next.js Proposal: Switch to app router of next.js Oct 14, 2023
@piyushgarg-dev piyushgarg-dev added enhancement New feature or request hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted labels Oct 15, 2023
@piyushgarg-dev
Copy link
Owner

Sounds Interesting 😄

@thakurthegr8
Copy link

I think app router is not yet stable thus we should stick with pages directory. Also it offers features like getserverside props which is useful in protecting pages and middlewares. What do you think about this? @piyushgarg-dev

@Umesh7Dixit
Copy link

Umesh7Dixit commented Oct 18, 2023

@Your-Ehsan Hello sir, I know Next.js 13 but it's too complicated to convert your review-app directory routing into app routing can you please help me . because u have many files, components and subfolders it's very complex to identify I glad if u help me.

@Your-Ehsan
Copy link
Author

@Umesh7Dixit Thanks for your interest. But at this time I just to confirm that If @piyushgarg-dev want this change in this project.

@Harshsharmaa28
Copy link

If not solved can you assing me @piyushgarg-dev @thakurthegr8

@piyushgarg-dev
Copy link
Owner

Hey, We are planning to move to hybrid model. Today we have pushed the public form router under app/ dir and made use of server components. Thanks a lot for suggestions 😄💪

@Your-Ehsan
Copy link
Author

Hey, We are planning to move to hybrid model. Today we have pushed the public form router under app/ dir and made use of server components. Thanks a lot for suggestions 😄💪

I'm glad you found my suggestion to convert the Next.js page router to an app router helpful. So, I think it's time to consider closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

No branches or pull requests

5 participants