Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix human bone assignment failure for gltf nodes[0] #577

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

saturday06
Copy link
Contributor

VRMHumanoidImporter.import() assigns VRM Humanoid bone name to glTF node. But glTF node with its index of zero is unexpectedly excluded from that assignment.

@saturday06 saturday06 requested a review from 0b5vr December 26, 2020 18:08
Co-authored-by: Yutaka "FMS_Cat" Obuchi <yutaka.obuchi@gmail.com>
@saturday06 saturday06 merged commit 3f58c62 into pixiv:dev Dec 28, 2020
@saturday06 saturday06 deleted the human_bone_node_index_zero branch December 28, 2020 01:20
@0b5vr 0b5vr added bug Something isn't working easy labels Dec 28, 2020
@0b5vr
Copy link
Contributor

0b5vr commented Dec 28, 2020

apparent. thanks!

@0b5vr 0b5vr added this to the next milestone Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants