Add OffscreenCanvas support for extractThumbnailBlob #511
Conversation
| // store the current resolution | ||
| renderer.getSize(_v2A); | ||
| const prevWidth = _v2A.x; | ||
| const prevHeight = _v2A.y; | ||
|
|
||
| // overwrite the resolution | ||
| renderer.setSize(size, size); | ||
| renderer.setSize(size, size, !(canvas instanceof OffscreenCanvas)); |
There was a problem hiding this comment.
Oh! I didn't know the third argument of setSize is true by default.
There is no reason resizing the style in this function, could you set false here instead? I also want to change revert to previous resolution one of course.
There was a problem hiding this comment.
Do you mean all renderer.setSize() in this method do not need to updateStyle?
|
I've never used offscreen canvas before but let me try this in this opportunity... |
|
It worked perfectly! |
|
uhhhh I just have noticed that the resize applies to the screen buffer for several frames since |
|
Anyway it looks excellent for me, thanks again! merging |
fixes #508