Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (humanoid): getPose / setPose is now working as intended #507

Merged
merged 5 commits into from
Oct 22, 2020
Merged

fix (humanoid): getPose / setPose is now working as intended #507

merged 5 commits into from
Oct 22, 2020

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Oct 20, 2020 •
edited
Loading

Should resolve #503

  • 🚨💡 Greatly changed the behavior of getPose / setPose
    • It now explicitly receives / returns local, relative transforms that is described in VRMPose
  • ✨ New method: resetPose
    • It just resets the pose to its restPose (that should be T stance)
  • 🚨💡 restPose is now explicitly not compatible with getPose / setPose
    • If you want to reset its pose, I have introduced resetPose so use this instead

@0b5vr 0b5vr added bug Something isn't working Breaking Change Choose wisely labels Oct 20, 2020
@0b5vr 0b5vr added this to the next milestone Oct 20, 2020
@0b5vr 0b5vr self-assigned this Oct 20, 2020
@0b5vr
Copy link
Contributor Author

0b5vr commented Oct 20, 2020

@JLChnToZ Does this look good for you?

@JLChnToZ
Copy link
Contributor

Yeah I think so, thanks a lot!

yomotsu
yomotsu approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@yomotsu yomotsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good❤️

@0b5vr
Copy link
Contributor Author

0b5vr commented Oct 21, 2020

thanks! gonna merge

@0b5vr 0b5vr merged commit a932a19 into dev Oct 22, 2020
@0b5vr 0b5vr deleted the fix-getpose branch October 22, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomotsu yomotsu yomotsu approved these changes

@JLChnToZ JLChnToZ JLChnToZ approved these changes

Assignees

@0b5vr 0b5vr

Labels
Breaking Change Choose wisely bug Something isn't working
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

model.humanoid.setPose(model.humanoid.restPose) Bug?
3 participants
@0b5vr @JLChnToZ @yomotsu