Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor (VRMSpringBone): A better way to cache the inverse of the world matrix #487

Merged
merged 1 commit into from
Sep 17, 2020
Merged

refactor (VRMSpringBone): A better way to cache the inverse of the world matrix #487

merged 1 commit into from
Sep 17, 2020

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Sep 17, 2020

Instead of extending THREE.Matrix4 , just observing matrix.elements using Proxy is good enough.

@0b5vr 0b5vr added the Refactor Cool code is cool label Sep 17, 2020
@0b5vr 0b5vr self-assigned this Sep 17, 2020
@0b5vr 0b5vr added this to the v0.4.1 milestone Sep 17, 2020
@0b5vr 0b5vr merged commit a87c428 into dev Sep 17, 2020
@0b5vr 0b5vr deleted the fix-spring-bone-inverse-cache branch September 17, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0b5vr 0b5vr

Labels
Refactor Cool code is cool
Projects
None yet
Milestone
v0.4.1
Development

Successfully merging this pull request may close these issues.
1 participant
@0b5vr