Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor (VRMSpringBone): Make most of constructor parameters an interface / make readonly parameters mutable #481

Merged
merged 2 commits into from
Sep 16, 2020
Merged

refactor (VRMSpringBone): Make most of constructor parameters an interface / make readonly parameters mutable #481

merged 2 commits into from
Sep 16, 2020

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Sep 15, 2020 •
edited
Loading

  • 🚨 The interface of new VRMSpringBone has changed
    • Used to have so many arguments, now have one required argument and one optional parameters object ( VRMSpringBoneParameters )
  • Most of members are now mutable
    • Since they don't have to be readonly

@0b5vr 0b5vr added Breaking Change Choose wisely Refactor Cool code is cool labels Sep 15, 2020
@0b5vr 0b5vr self-assigned this Sep 15, 2020
@0b5vr 0b5vr added this to the next milestone Sep 15, 2020
@0b5vr 0b5vr merged commit 5aca0eb into dev Sep 16, 2020
@0b5vr 0b5vr deleted the springbone-params branch September 16, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0b5vr 0b5vr

Labels
Breaking Change Choose wisely Refactor Cool code is cool
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@0b5vr