Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of gltf meshes with children is still wrong #623

Closed
0b5vr opened this issue Feb 8, 2021 · 0 comments · Fixed by #624
Closed

Handling of gltf meshes with children is still wrong #623

0b5vr opened this issue Feb 8, 2021 · 0 comments · Fixed by #624
Assignees
Labels
bug Something isn't working
Milestone

Comments

@0b5vr
Copy link
Contributor

0b5vr commented Feb 8, 2021

Turned out that what I did in #588 was totally wrong! 🙇

Actual tree of objects are like this:

- `THREE.Group` The target node (that used to be traversed)
    - `THREE.Group` **A group that contains all the mesh primitives** 
        - `THREE.Mesh` A primitive of the target node
        - `THREE.Mesh` A primitive of the target node (2)
    - `THREE.Group` A child node with a mesh
        - `THREE.Group` **A group that contains all the mesh primitives** 
            - `THREE.Mesh` A primitive of the child node, that should not be processed using traverse
            - `THREE.Mesh` A primitive of the child node, that should not be processed using traverse (2)

Seems we have to fix the function gltfExtractPrimitivesFromNode again.

@0b5vr 0b5vr added the bug Something isn't working label Feb 8, 2021
@0b5vr 0b5vr added this to the next milestone Feb 8, 2021
@0b5vr 0b5vr self-assigned this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant