From 1a55f68935279cd98a505f02203ff92b482f9094 Mon Sep 17 00:00:00 2001 From: clavedeluna Date: Tue, 24 Sep 2024 11:33:40 -0300 Subject: [PATCH 1/2] add debug statement when no files match --- src/codemodder/codemods/base_codemod.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/codemodder/codemods/base_codemod.py b/src/codemodder/codemods/base_codemod.py index cb338b2d..8993859d 100644 --- a/src/codemodder/codemods/base_codemod.py +++ b/src/codemodder/codemods/base_codemod.py @@ -222,6 +222,9 @@ def _apply( return files_to_analyze = self.get_files_to_analyze(context, results) + if not files_to_analyze: + logger.debug("No files matched for %s", self.id) + return process_file = functools.partial( self._process_file, context=context, results=results, rules=rules From c2a33ed87bf6a455d42a92ee70a744ec5ba8d1ff Mon Sep 17 00:00:00 2001 From: "pixeebot[bot]" <104101892+pixeebot[bot]@users.noreply.github.com> Date: Tue, 24 Sep 2024 12:50:37 -0300 Subject: [PATCH 2/2] Hardening suggestions for codemodder-python / debug-file (#852) Use Assignment Expression (Walrus) In Conditional Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com> --- src/codemodder/codemods/base_codemod.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/codemodder/codemods/base_codemod.py b/src/codemodder/codemods/base_codemod.py index 8993859d..c85870ba 100644 --- a/src/codemodder/codemods/base_codemod.py +++ b/src/codemodder/codemods/base_codemod.py @@ -221,8 +221,7 @@ def _apply( logger.debug("No results for %s", self.id) return - files_to_analyze = self.get_files_to_analyze(context, results) - if not files_to_analyze: + if not (files_to_analyze := self.get_files_to_analyze(context, results)): logger.debug("No files matched for %s", self.id) return