Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-missing-self-or-cls is missing self.node_is_selected check #413

Closed
clavedeluna opened this issue Mar 26, 2024 · 1 comment · Fixed by #423
Closed

fix-missing-self-or-cls is missing self.node_is_selected check #413

clavedeluna opened this issue Mar 26, 2024 · 1 comment · Fixed by #423
Assignees
Labels
bug Something isn't working

Comments

@clavedeluna
Copy link
Contributor

All codemods should have logic similar to self.node_is_selected to check if results exist for this codemod. When writing this codemod we forgot to update sonar_issues.json which made the integration test for this codemod pass. However, adding the self.node_is_selected would've alerted us to having forgotten to add a corresponding sonar issue.

@drdavella
Copy link
Member

I'm curious whether this failure is related: https://github.com/pixee/codemodder-python/actions/runs/8420800708/job/23056254528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants