Added credentials option for iter_bucket. #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes issue piskvorky#259
mpenkov
requested changes
Oct 31, 2019
There was a problem hiding this comment.
Thank you for your contribution. I had a closer look and left you some comments.
Also, please avoid force-pushing during a review, because it destroys history, making it impossible for the reviewer to distinguish between new changes and changes they've already looked at in the past.
mpenkov
reviewed
Nov 4, 2019
smart_open/s3.py
Outdated
| def _list_bucket(bucket_name, prefix='', accept_key=lambda k: True, | ||
| aws_access_key_id=None, aws_secret_access_key=None, | ||
| aws_session_token=None): | ||
| client = boto3.client('s3', |
There was a problem hiding this comment.
Hanging indent here please.
mpenkov
reviewed
Nov 4, 2019
|
@derpferd Ping. Are you able to finish this PR? |
|
@mpenkov Sorry for the delay, made the formatting suggestion and changed to use key word args instead. |
mpenkov
reviewed
Jan 23, 2020
smart_open/s3.py
Outdated
| prefix='', | ||
| accept_key=lambda k: True, | ||
| **session_kwargs): | ||
| client = boto3.client('s3', **session_kwargs) |
There was a problem hiding this comment.
You're passing session kwargs to the client, will that really work for all keywords?
|
Merged. @derpferd Thank you for your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes issue #259