Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing wheels for Windows #2600

Closed
piskvorky opened this issue Sep 9, 2019 · 12 comments
Closed

Missing wheels for Windows #2600

piskvorky opened this issue Sep 9, 2019 · 12 comments
Assignees
Labels
bug Issue described a bug

Comments

@piskvorky
Copy link
Owner

piskvorky commented Sep 9, 2019

Lately, there's been a stream of issues from Windows users, e.g. here.

Looking at PyPI, it seems binary wheels are completely missing from the last few distributions (incl. the latest 3.8.0):
https://pypi.org/project/gensim/#files

This means Windows users don't get to install the optimized Gensim easily, and unless they have a compiler properly set up, they'll install the slow (uncompiled) version of word2vec, fastttext etc.

We definitely want those binary wheels on PyPI, especially for Windows. Windows users are the least tech-savvy, least likely to have a C compiler, and most likely to raise confused support tickets.

@piskvorky piskvorky added the bug Issue described a bug label Sep 9, 2019
@piskvorky
Copy link
Owner Author

piskvorky commented Sep 9, 2019

The last distribution with Windows wheels seems to be 3.7.1, from January 2019:
https://pypi.org/project/gensim/3.7.1/#files

@mpenkov IIRC this coincides with you taking over from @menshikh-iv – did you perhaps forget some release steps?

@mpenkov
Copy link
Collaborator

mpenkov commented Sep 9, 2019

@piskvorky I had a look, the problem is caused by failing AppVeyor builds (we use Travis CI for Linux and Mac, and AppVeyor for Windows). During the handover, I spent a lot of time dealing with problems in Travis CI, and neglected to check AppVeyor. Since the builds were failing, the Windows wheels weren't being built.

I'll investigate why the builds are failing - it seems to be a MemoryError in FastText code (https://ci.appveyor.com/project/piskvorky/gensim-wheels/builds/25836814/job/8yiy55wlf43soy01). Since the tests pass everywhere else, I suspect the AppVeyor machine is genuinely running out of memory, but I will need to double-check this.

Once that's fixed, I'll add some failsafes to prevent this from happening again:

  1. Update documentation to explicitly focus on both Travis CI and AppVeyor (right now, it just mentions CI vaguely)
  2. Add automatic checks for wheels for all platforms before finalizing the release

@piskvorky
Copy link
Owner Author

OK, thanks. This is important, definitely warrants a new "bugfix release".

@piskvorky
Copy link
Owner Author

piskvorky commented Sep 16, 2019

@mpenkov do you have an ETA on those wheels being on PyPI?

Also needed here https://groups.google.com/d/msg/gensim/3ms1iH_Miuc/Wej0Go7EAQAJ

Having an internal automated checking process will be nice, but not as urgent as having the wheels actually available for Windows users.

@mpenkov
Copy link
Collaborator

mpenkov commented Sep 17, 2019

@piskvorky No ETA at the moment, but I'm working on it. I'm going to try skip the tests altogether and rebuild the wheels for the current release. Ideally, we'd figure out what's causing those MemoryErrors on appveyor, but that's going to take substantially longer.

@piskvorky
Copy link
Owner Author

piskvorky commented Sep 19, 2019

OK, thanks. The sooner the better, this is awkward (another request today and one more).

@mpenkov
Copy link
Collaborator

mpenkov commented Sep 20, 2019

I got the wheels to build (see https://ci.appveyor.com/project/piskvorky/gensim-wheels), and those wheels should be uploaded to rackspace. I'm having trouble downloading them, because they don't appear to be where I'm expecting them (see http://b153eb958f4da6029aca-3f9dff7fe564350f10153d8c7bfc5ab6.r54.cf2.rackcdn.com/, no Windows wheels for 3.8.0 there).

@menshikh-iv Any ideas where I can get the built wheels?

@mpenkov
Copy link
Collaborator

mpenkov commented Sep 23, 2019

@piskvorky I couldn't find the new wheels, so I'm going to make a bugfix 3.8.1 release, and hope that the wheels get built properly as part of the release process. I'll let you know how that goes within a day or so, when the CI chews through the jobs.

@mpenkov
Copy link
Collaborator

mpenkov commented Sep 26, 2019

@piskvorky I still couldn't get the CI to publish the wheels, but I was able to download them manually and include them in the 3.8.1 release.

@mpenkov
Copy link
Collaborator

mpenkov commented Sep 26, 2019

Opened MacPython/gensim-wheels#15. We'll have to deal with that issue separately.

@menshikh-iv
Copy link
Contributor

So, we found a reason, this will be fixed soon

@mpenkov
Copy link
Collaborator

mpenkov commented Sep 29, 2019

Yay, thanks @menshikh-iv !

@mpenkov mpenkov closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue described a bug
Projects
None yet
Development

No branches or pull requests

3 participants