Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Word2vec multiple passes more explicit #1052

Closed
tmylk opened this issue Dec 21, 2016 · 2 comments
Closed

Make Word2vec multiple passes more explicit #1052

tmylk opened this issue Dec 21, 2016 · 2 comments
Labels
difficulty easy Easy issue: required small fix wishlist Feature request

Comments

@tmylk
Copy link
Contributor

tmylk commented Dec 21, 2016

As discussed on the mailing list

Perhaps `train()` should require an explicit (non-default) `passes` parameter. In the 1-liner/initialization-trains case, it'd be called with the 'iter' value. For anyone calling it themselves, they'd have to make an explicit choice of 'passes'. And after the change, any old code without the parameter would (by design) break, forcing a change to explicit specification. 

Perhaps even `alpha` and `min_alpha` should be explicit required parameters to `train()`, to ensure those calling it directly aren't see-sawing the values each call. Calling 'train()' directly is kind of an advanced approach, so requiring this level of choice may be appropriate. 

@tmylk tmylk added difficulty easy Easy issue: required small fix wishlist Feature request labels Dec 21, 2016
@SND96
Copy link

SND96 commented Dec 22, 2016

@tmylk Would like to work on this issue.

@tmylk
Copy link
Contributor Author

tmylk commented Mar 8, 2017

wip in #1139

@tmylk tmylk closed this as completed in becc6d3 Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty easy Easy issue: required small fix wishlist Feature request
Projects
None yet
Development

No branches or pull requests

2 participants