Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which .css is better to hide new tab button completely? #1591

Closed
SXZ1 opened this issue Nov 20, 2017 · 4 comments
Closed

Which .css is better to hide new tab button completely? #1591

SXZ1 opened this issue Nov 20, 2017 · 4 comments

Comments

@SXZ1
Copy link

SXZ1 commented Nov 20, 2017

I want to hide new tab button completely in both overflow mode (sidebar height is not enough to fit all tabs, scrollbar appears) and non-overflow mode (sidebar height is enough to fit all tabs, scrollbar is gone)
First code:

#tabbar:not(.overflow) .after-tabs {
display: none;
}
#tabbar.overflow ~ .after-tabs {
display: none;
}

Second code:

.newtab-button-box {
display: none;
}

@irvinm
Copy link
Contributor

irvinm commented Nov 20, 2017

I have also seen:

#tabbar .after-tabs { display: none !important; }

At the end of the day, I am not sure there is much difference between each implementation. I would think your "Second code:" or this one are more simplistic and slightly better.

@wdnz
Copy link

wdnz commented Nov 24, 2017

I also use the second one without issues.

@piroor
Copy link
Owner

piroor commented Nov 27, 2017

I think .newtab-button-box { display: none; } is good enough.

@SXZ1
Copy link
Author

SXZ1 commented Nov 27, 2017

Thank you very much!

@SXZ1 SXZ1 closed this as completed Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants