Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codegen image version #5430

Closed
khanhtc1202 opened this issue Dec 17, 2024 · 0 comments · Fixed by #5436
Closed

Update codegen image version #5430

khanhtc1202 opened this issue Dec 17, 2024 · 0 comments · Fixed by #5436
Labels
kind/bug Something isn't working

Comments

@khanhtc1202
Copy link
Member

khanhtc1202 commented Dec 17, 2024 •
edited
Loading

What happened:

Whenever updating the codegen image version, regenerate pipecd code (proto) causes unexpected changes as in the picture below

Screenshot 2024-12-17 at 15 18 44

Related change/workaround which fixed this before: #4972

What you expected to happen:

How to reproduce it:

  1. Try updating the version of codegen image to whatever versions listed in https://github.com/pipe-cd/pipecd/pkgs/container/codegen
  2. Run make gen/code

Environment:

  • piped version:
  • control-plane version:
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix to parse protoreflect.Message instead of parsing the value returned by v.String() pipe-cd/pipecd
1 participant
@khanhtc1202