From 9ec25031ff055a9ae9636cef324f3f0348780df3 Mon Sep 17 00:00:00 2001 From: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Date: Mon, 5 Aug 2024 08:00:51 +0700 Subject: [PATCH] Add note to application delete field (#5101) Signed-off-by: khanhtc1202 --- pkg/model/application.pb.go | 4 ++++ pkg/model/application.proto | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/pkg/model/application.pb.go b/pkg/model/application.pb.go index c3d02ccd41..650192a142 100644 --- a/pkg/model/application.pb.go +++ b/pkg/model/application.pb.go @@ -133,6 +133,10 @@ type Application struct { // Unix time when the application was deleted. DeletedAt int64 `protobuf:"varint,98,opt,name=deleted_at,json=deletedAt,proto3" json:"deleted_at,omitempty"` // Whether the application is deleted or not. + // + // NOTE: + // PipeCD logic with application should NOT reply on this field. + // Use `disabled` field instead. Deleted bool `protobuf:"varint,99,opt,name=deleted,proto3" json:"deleted,omitempty"` // Whether the application is disabled or not. Disabled bool `protobuf:"varint,100,opt,name=disabled,proto3" json:"disabled,omitempty"` diff --git a/pkg/model/application.proto b/pkg/model/application.proto index 00a878c0ab..1d0d5c0394 100644 --- a/pkg/model/application.proto +++ b/pkg/model/application.proto @@ -62,6 +62,10 @@ message Application { // Unix time when the application was deleted. int64 deleted_at = 98 [(validate.rules).int64.gte = 0]; // Whether the application is deleted or not. + // + // NOTE: + // PipeCD logic with application should NOT reply on this field. + // Use `disabled` field instead. bool deleted = 99; // Whether the application is disabled or not. bool disabled = 100;