Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an operator page to show application counts of all projects #2015

Merged
merged 2 commits into from
May 27, 2021

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented May 27, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1511

Does this PR introduce a user-facing change?:

The operator now can see the number of application of projects

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/app/ops/handler/handler_test.go
--- pkg/app/ops/handler/handler_test.go.orig
+++ pkg/app/ops/handler/handler_test.go
@@ -18,8 +18,9 @@
 	"bytes"
 	"testing"
 
-	"github.com/pipe-cd/pipe/pkg/model"
 	"github.com/stretchr/testify/assert"
+
+	"github.com/pipe-cd/pipe/pkg/model"
 )
 
 func TestMakeApplicationCounts(t *testing.T) {

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.62%. This pull request decreases coverage by -0.28%.

File Function Base Head Diff
pkg/app/ops/handler/handler.go NewHandler -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.Run -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.run -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.stop -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.handleTop -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.handleListProjects -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.handleAddProject -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.handleApplicationCounts -- 0.00% +0.00%
pkg/app/ops/handler/handler.go groupApplicationCounts -- 100.00% +100.00%

@khanhtc1202
Copy link
Member

Nice
/lgtm

Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 5bf1c4d into master May 27, 2021
@pipecd-bot pipecd-bot deleted the ops-insight branch May 27, 2021 06:44
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule manifests

Details
Error: unabled to render file: manifests/pipecd/prom-rules/alerting_rules.yml, err: template: template-plugin:11: undefined variable "$labels"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show application insight to operator
4 participants