Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yup version #1999

Merged
merged 1 commit into from
May 25, 2021
Merged

Update yup version #1999

merged 1 commit into from
May 25, 2021

Conversation

cakecatz
Copy link
Contributor

@cakecatz cakecatz commented May 25, 2021

What this PR does / why we need it:

Update yup version

https://github.com/jquense/yup/blob/master/CHANGELOG.md#breaking-changes-1
It has breaking changes and I changed code to support them.
https://github.com/pipe-cd/pipe/pull/1999/files#diff-5f84f83f8add53688ff4a0aaf614aa5f91e3f1ddeefe35214304c497a5ba28b2R25

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.93%. This pull request increases coverage by 0.07%.

File Function Base Head Diff
pkg/app/api/grpcapi/web_api.go WebAPI.GetInsightApplicationCount 0.00% 0.00% +0.00%
pkg/app/ops/insightcollector/applications.go Collector.updateApplicationCounts 0.00% 0.00% +0.00%
pkg/insight/applicationcount.go MakeApplicationCounts 0.00% 100.00% +100.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 85.70%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

Nice 🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants