Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combat.lua expects ships to have default hyperdrive class > 1 (ship rebalance) #4983

Closed
WKFO opened this issue Oct 25, 2020 · 4 comments · Fixed by #5002
Closed

Combat.lua expects ships to have default hyperdrive class > 1 (ship rebalance) #4983

WKFO opened this issue Oct 25, 2020 · 4 comments · Fixed by #5002

Comments

@WKFO
Copy link
Contributor

WKFO commented Oct 25, 2020

Observed behaviour

I finished a recon mission and just when I exit hyperspace to the payment system, game crashes. Consistent. I have a save file below. (For clarification, you can jump to other systems just fine. It is the payment system that is problematic.)

aaa

Expected behaviour

No crash.

Steps to reproduce

https://www.dropbox.com/s/sh728r3i83ow5ac/Bugreport?dl=0
Load the save file and click hyperspace.

My pioneer version (and OS):
42b67ec + Nozmajner's latest ship rebalance (Windows 10 x64)

@The-EG
Copy link
Contributor

The-EG commented Oct 25, 2020

Just a quick glance at the lua: it looks like it's trying to spawn a ship of one of the types: 'medium_fighter', 'medium_courier', 'light_freighter' and also has a hyperdrive class > 1. I'm guessing the number of ships that meet that criteria is now 0 for some reason, so it doesn't like generating a random number between 1 and 0.

@bszlrd
Copy link
Contributor

bszlrd commented Oct 25, 2020

Hmm, so the default hyperdrives are too low in the rebalance for some ships? Why the mission wants ships that have larger than class 1 hyperdrives?

@bszlrd bszlrd mentioned this issue Oct 25, 2020
3 tasks
@robothauler
Copy link
Contributor

Why the mission wants ships that have larger than class 1 hyperdrives?

The intention was to choose only the faster ships. But I think this doesn't matter and can be changed to the usually hyperdrive class > 0.

@The-EG The-EG changed the title Combat.lua random integer fail(?) Combat.lua expects ships to have default hyperdrive class > 1 (ship rebalance) Oct 25, 2020
@impaktor
Copy link
Member

impaktor commented Nov 7, 2020

@robothauler do you have time to look into this, so it's robust to this re-balance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants