Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NameGen.lua #3601

Closed
fluffyfreak opened this issue Jan 21, 2016 · 2 comments · Fixed by #5223
Closed

Update NameGen.lua #3601

fluffyfreak opened this issue Jan 21, 2016 · 2 comments · Fixed by #5223
Assignees

Comments

@fluffyfreak
Copy link
Contributor

It's been a while since NameGen.lua was updated so maybe we should do a pass and make sure we've got all the contributor names added.

Also there's more male than female names, probably as we're mostly male on the project (?), so if anyone can think of family members names that aren't in there then mention them in a reply post as we can fix that up too.

@impaktor
Copy link
Member

Funny, this is exactly what I'm working on, and been tumbling in my head for the past weeks.

I have compiled a shit load of data with most common first and last names from most "big" countries, (Spanish, French, German, Russian, Japanese, Chinese, Greek, Italian, UK, ...).

I've been talking with @laarmen about how to best implement it. I want each system to have its own "culture"-constant, so BBS is dominated by Chinese names if the system has a Chinese culture.

@laarmen suggested storing names/cultures as json, since it's data, but that has the downside of not being able to tweak names, like Russian last names are suffixed with "a" if it's a female first name (e.q. impaktov, impaktova). And don't get me stared on those Hungarian bastards, who are all backwards!

So I'm still thinking about how each culture should define its own firstname and lastname function. My problem is thinking through which strategy is best for all of this. (How/when is culture assigned to a system? In C++? Culture constans are exposed to both C++ and Lua? From where? etc.)

So I'm still a bit in Lua-C++ limbo.

Also, I don't have a branch of this yet.

@impaktor
Copy link
Member

@impaktor impaktor mentioned this issue Jun 27, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants