Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[phd-table]: Cannot pass specific properties on cell click #12

Open
jmzagorski opened this issue Apr 2, 2020 · 0 comments
Open

[phd-table]: Cannot pass specific properties on cell click #12

jmzagorski opened this issue Apr 2, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@jmzagorski
Copy link
Contributor

jmzagorski commented Apr 2, 2020

e.g.

renderer: (): string =>
  `<a href="javascript:void(0)"
        click.delegate="_setFilter(row.item.item.displayName)"
    >\${row.item.item.displayName}</a>`

does not pass the nested item.displayName property. It always passes the row. Ideally we should use cell-click.call=externalFunction(args), might be better than just passing the row arg on click.

The binding in general is not setup great or wrorking as easy as I hope...e.g a click target may be the inner text of the button and ot the element with click.delegate

Checkout the event-manager in aurelia-binding repo for improvements

@jmzagorski jmzagorski added the enhancement New feature or request label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant