Pino fails to flush on process exit when lots of data

[erezarnon]

It doesn't happen every time, but very often if you run the below, This is a test error, won't get logged. Interestingly, it's only reproducible with the pino-pretty target (not sure if I should file it there).

import pino from 'pino';

const logger = pino({
  transport: {
    target: 'pino-pretty',
  },
});

function main() {
  const longString = 'x'.repeat(100000);
  logger.error(longString);
  throw new Error('This is a test error');
}

if (require.main === module) {
  try {
    main();
  } catch (e) {
    logger.error(e.message);
  }
}

[jsumners]

Transports are executed in a separate thread. Worker threads get destroyed at

pino/lib/transport.js

Lines 32 to 55 in 7cff45a

	process.on('exit', onExit)
	function onReady () {
	process.removeListener('exit', onExit)
	stream.unref()
	if (workerOpts.autoEnd !== false) {
	setupOnExit(stream)
	}
	}
	function onExit () {
	/* istanbul ignore next */
	if (stream.closed) {
	return
	}
	stream.flushSync()
	// Apparently there is a very sporadic race condition
	// that in certain OS would prevent the messages to be flushed
	// because the thread might not have been created still.
	// Unfortunately we need to sleep(100) in this case.
	sleep(100)
	stream.end()
	}

I suspect the thread is destroyed before logger.error is fired.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.