Error: "fn is not a function" while setting up a pino transports since v9.2.1

[viceice]

Pino v9.3.0 throws errors

#10 23.21 5e4f8d756c2d9898b115a52167c82923990c1c73 (Node v20.11.1)
#10 23.22 node:events:496
#10 23.22       throw er; // Unhandled 'error' event
#10 23.22       ^
#10 23.22 
#10 23.22 TypeError: fn is not a function
#10 23.22     at /snapshot/dist/pino-worker.js:10
#10 23.22     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
#10 23.22     at async Promise.all (index 0)
#10 23.22     at async module.exports (/snapshot/dist/pino-worker.js:10713:15)
#10 23.22     at async start (/snapshot/dist/thread-stream-worker.js:134:17)
#10 23.22 Emitted 'error' event on ThreadStream instance at:
#10 23.22     at Immediate.<anonymous> (/snapshot/dist/containerbase-cli.js:6481:17)
#10 23.22     at process.processImmediate (node:internal/timers:4

Update PR

• fix(deps): update dependency pino to v9.3.2 containerbase/base#2942

Logger init code

• https://github.com/containerbase/base/blob/main/src/cli/utils/logger.ts

The code will be transpiled with esbuild and then packaged with @yao-pkg/pkg

• https://github.com/containerbase/base/blob/main/tools/esbuild.js

Seems to be related to #1383

[mcollina]

We do our best to avoid regressions. I actually have no clue on why this problem is happening in your codebase. I would recommend you to send a PR to fix this.

[viceice]

ok , found it's failing here

pino/lib/worker.js

Line 103 in 8aafa88

const stream = await fn(t.options)

so it seems loadTransportStreamBuilder returns null or undefined 🤔

[viceice]

ha, found it #1990

pino/lib/transport-stream.js

Line 34 in 8aafa88

return

that return is causing to skip these important lines:

pino/lib/transport-stream.js

Lines 49 to 54 in 8aafa88

	// Depending on how the default export is performed, and on how the code is
	// transpiled, we may find cases of two nested "default" objects.
	// See https://github.com/pinojs/pino/issues/1243#issuecomment-982774762
	if (typeof fn === 'object') fn = fn.default
	if (typeof fn === 'object') fn = fn.default
	if (typeof fn !== 'function') throw Error('exported worker is not a function')

[viceice]

btw v9.2.1 was not published to npmjs.org

[mcollina]

Can you send a PR that fixes this and adds a test?

[viceice]

sure :-)

[viceice]

here it is 💪

• fix: no early return in loadTransportStreamBuilder #2014

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.