Add midnight-smoker to do some basic integration testing

[mcollina]

Check out https://www.npmjs.com/package/midnight-smoker.

The goal is to catch configuration and dependency errors, e.g. a needed dependency wrongly classified as a devDepedency.

[Nabhag8848]

Hey @mcollina. I would like to work, can you assign it to me.

[mcollina]

go for it!

[Nabhag8848]

Hey @mcollina, while running midnight-smoker against pre-publish lifecycle script. i have found that tap module is install as devDependency instead of dependency which is giving following Error: cannot find module tap.

When tap is install as devDependency:

When tap is install as dependency:

• Thus, will need changes to install tap as dependency. currently tap has latest release of v16.3.2 and we are currently having v16.2.0. should i go about installing the latest release or the version which already exist?

[jsumners]

tap is and always should be a development dependency.

[dancastillo]

hey @Nabhag8848 are you still working on this? If not can I take it up

[Nabhag8848]

hey @Nabhag8848 are you still working on this? If not can I take it up

Hey, Go ahead. I missed this and its been too long.

[dancastillo]

@mcollina midnight-smoker needs npm v7.0.0 in github actions CI check node 14 installs npm v6.14.18.
Would a github action be better? resource

[jsumners]

I don't understand how they can claim Node 14 support when it doesn't ship with npm@7.

[mcollina]

A separate github action is better.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.