Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance graceful shutdown procedure #399

Closed
djshow832 opened this issue Nov 14, 2023 · 0 comments · Fixed by #400
Closed

Enhance graceful shutdown procedure #399

djshow832 opened this issue Nov 14, 2023 · 0 comments · Fixed by #400
Assignees
@djshow832

Comments

@djshow832
Copy link
Collaborator

Development Task

On the cloud, NLB takes around 90s to mark TiProxy offline after TiProxy shuts down the HTTP port. During this process, new connections are denied.

Proposal:

  • Only reject new connections after graceful-wait-before-shutdown, not before
  • Add a configuration graceful-close-conn-timeout. After graceful-wait-before-shutdown, reject new connections and close connections that have finished transactions, until graceful-close-conn-timeout ends
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djshow832 djshow832

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

proxy, config: add config graceful-close-conn-timeout djshow832/TiProxy
1 participant
@djshow832