-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coprocessor/scanner: set key_only=true if needed #2580
Conversation
LGTM. |
/run-all-tests |
ci failed. |
&self.store, | ||
ScanOn::Table, | ||
self.desc, | ||
self.col_ids.is_empty(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about handle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle
wouldn't appear in self.col_ids
since it was filtered on L47 @BusyJay
/run-all-tests |
LGTM |
Performance test result(with long value in default cf) in master
current branch
|
@BusyJay @hicqu @hanfei1991 PTAL