Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor/scanner: set key_only=true if needed #2580

Merged
merged 8 commits into from
Dec 22, 2017

Conversation

AndreMouche
Copy link
Member

@hicqu
Copy link
Contributor

hicqu commented Dec 13, 2017

LGTM.

@ngaut
Copy link
Member

ngaut commented Dec 13, 2017

/run-all-tests

@zhangjinpeng87
Copy link
Member

ci failed.

&self.store,
ScanOn::Table,
self.desc,
self.col_ids.is_empty(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about handle?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle wouldn't appear in self.col_ids since it was filtered on L47 @BusyJay

@AndreMouche
Copy link
Member Author

/run-all-tests

@hanfei1991
Copy link
Member

LGTM

@AndreMouche
Copy link
Member Author

AndreMouche commented Dec 19, 2017

Performance test result(with long value in default cf)
tidb branch(pingcap/tidb#5447):

in master

MySQL [test]> select count(*) from table10;
+-----------+
| count(*)  |
+-----------+
| 264488600 |
+-----------+
1 row in set (1 min 31.44 sec)

MySQL [test]> select count(*) from table10;
+-----------+
| count(*)  |
+-----------+
| 264488600 |
+-----------+
1 row in set (1 min 31.54 sec)

MySQL [test]> select count(*) from table10;
+-----------+
| count(*)  |
+-----------+
| 264488600 |
+-----------+
1 row in set (1 min 31.30 sec)

MySQL [test]> select count(*) from table10;
+-----------+
| count(*)  |
+-----------+
| 264488600 |
+-----------+
1 row in set (1 min 31.19 sec)

current branch

MySQL [test]> select count(*) from table10;
+-----------+
| count(*)  |
+-----------+
| 264488600 |
+-----------+
1 row in set (1 min 1.98 sec)

MySQL [test]> select count(*) from table10;
+-----------+
| count(*)  |
+-----------+
| 264488600 |
+-----------+
1 row in set (1 min 2.04 sec)

MySQL [test]> select count(*) from table10;
+-----------+
| count(*)  |
+-----------+
| 264488600 |
+-----------+
1 row in set (1 min 2.04 sec)

MySQL [test]> select count(*) from table10;
+-----------+
| count(*)  |
+-----------+
| 264488600 |
+-----------+
1 row in set (1 min 1.92 sec)

@hicqu hicqu merged commit 8c1fe30 into tikv:master Dec 22, 2017
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants