Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and bugfix for resolve lock logic #2872

Open
1 of 2 tasks
Tracked by #4849
amyangfei opened this issue Sep 22, 2021 · 2 comments
Open
1 of 2 tasks
Tracked by #4849

Refactor and bugfix for resolve lock logic #2872

amyangfei opened this issue Sep 22, 2021 · 2 comments
Assignees
Labels
component/kv-client TiKV kv log client component. subject/new-feature Denotes an issue or pull request adding a new feature.

Comments

@amyangfei
Copy link
Contributor

amyangfei commented Sep 22, 2021

Feature Request

Is your feature request related to a problem? Please describe:

A known bug from #2867, if the resolved-ts of a region is fallen back, the resolved ts update event won't be sent in L762.

https://github.com/pingcap/ticdc/blob/67f994db6dbc9121ed2c881feb88c4d97387dcd8/cdc/kv/region_worker.go#L742-L764

In this scenario, the penalty of a region won't increase and resolve lock won't launch until the region is reconnected.

https://github.com/pingcap/ticdc/blob/67f994db6dbc9121ed2c881feb88c4d97387dcd8/cdc/kv/region_worker.go#L359-L376

Describe the feature you'd like:

@amyangfei amyangfei added component/kv-client TiKV kv log client component. subject/new-feature Denotes an issue or pull request adding a new feature. labels Sep 22, 2021
@maxshuang
Copy link
Contributor

@amyangfei @overvenus is there any good way to simulate "kill db instance and leave some lock in region" ?

@amyangfei
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/kv-client TiKV kv log client component. subject/new-feature Denotes an issue or pull request adding a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants