From 76d5e3f3949d17f3905325f96276e43d18d08c88 Mon Sep 17 00:00:00 2001
From: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date: Thu, 21 Jul 2022 17:53:09 +0800
Subject: [PATCH] fix a panic issue in parallel agg when exception is thrown
 (#5433) (#5437)

close pingcap/tiflash#5356
---
 dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp b/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp
index bf41084e247..758f11c1f0a 100644
--- a/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp
+++ b/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp
@@ -182,10 +182,9 @@ void ParallelAggregatingBlockInputStream::Handler::onFinish()
 void ParallelAggregatingBlockInputStream::Handler::onException(std::exception_ptr & exception, size_t thread_num)
 {
     parent.exceptions[thread_num] = exception;
-    /// can not cancel parent inputStream or the exception might be lost
     if (!parent.executed)
         /// kill the processor so ExchangeReceiver will be closed
-        parent.processor.cancel(true);
+        parent.cancel(true);
 }