From bb6f7680269c087094134cc6010f200dfd12dfca Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Thu, 25 Jan 2024 19:41:51 +0800 Subject: [PATCH 1/2] *: tidb_opt_use_invisible_indexes support set_var Signed-off-by: Weizhen Wang --- tests/integrationtest/r/sessionctx/setvar.result | 12 ++++++++++++ tests/integrationtest/t/sessionctx/setvar.test | 4 ++++ 2 files changed, 16 insertions(+) diff --git a/tests/integrationtest/r/sessionctx/setvar.result b/tests/integrationtest/r/sessionctx/setvar.result index 8e1916e8baa7c..8be4f8164d5e0 100644 --- a/tests/integrationtest/r/sessionctx/setvar.result +++ b/tests/integrationtest/r/sessionctx/setvar.result @@ -1668,6 +1668,18 @@ select /*+ set_var(tidb_init_chunk_size=3) */ @@tidb_init_chunk_size; select @@tidb_init_chunk_size; @@tidb_init_chunk_size 1 +select /*+ set_var(tidb_opt_use_invisible_indexes=on) */ @@tidb_opt_use_invisible_indexes; +@@tidb_opt_use_invisible_indexes +1 +select @@tidb_opt_use_invisible_indexes; +@@tidb_opt_use_invisible_indexes +0 +select /*+ set_var(tidb_opt_use_invisible_indexes=off) */ @@tidb_opt_use_invisible_indexes; +@@tidb_opt_use_invisible_indexes +0 +select @@tidb_opt_use_invisible_indexes; +@@tidb_opt_use_invisible_indexes +0 set @@global.max_execution_time=1000; select @@max_execution_time; @@max_execution_time diff --git a/tests/integrationtest/t/sessionctx/setvar.test b/tests/integrationtest/t/sessionctx/setvar.test index 915e98e385e3f..55d1a72eae47b 100644 --- a/tests/integrationtest/t/sessionctx/setvar.test +++ b/tests/integrationtest/t/sessionctx/setvar.test @@ -680,6 +680,10 @@ select @@tidb_max_chunk_size; select @@tidb_init_chunk_size; select /*+ set_var(tidb_init_chunk_size=3) */ @@tidb_init_chunk_size; select @@tidb_init_chunk_size; +select /*+ set_var(tidb_opt_use_invisible_indexes=on) */ @@tidb_opt_use_invisible_indexes; +select @@tidb_opt_use_invisible_indexes; +select /*+ set_var(tidb_opt_use_invisible_indexes=off) */ @@tidb_opt_use_invisible_indexes; +select @@tidb_opt_use_invisible_indexes; set @@global.max_execution_time=1000; connect (conn1,localhost,root,,sessionctx__setvar); From 0ee23e9e37ff45d8671b7ed3a799367dff716c5b Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Thu, 25 Jan 2024 19:42:04 +0800 Subject: [PATCH 2/2] *: tidb_opt_use_invisible_indexes support set_var Signed-off-by: Weizhen Wang --- pkg/sessionctx/variable/setvar_affect.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/sessionctx/variable/setvar_affect.go b/pkg/sessionctx/variable/setvar_affect.go index 17b7fbfd7d7eb..866dd611fcf33 100644 --- a/pkg/sessionctx/variable/setvar_affect.go +++ b/pkg/sessionctx/variable/setvar_affect.go @@ -53,6 +53,7 @@ var isHintUpdatableVerified = map[string]struct{}{ "tidb_opt_disk_factor": {}, "tidb_opt_concurrency_factor": {}, "tidb_opt_force_inline_cte": {}, + "tidb_opt_use_invisible_indexes": {}, "tidb_index_join_batch_size": {}, "tidb_index_lookup_size": {}, "tidb_index_serial_scan_concurrency": {},