From 265ab11d56520563d2c8488122b0629683de54fe Mon Sep 17 00:00:00 2001 From: tiancaiamao Date: Wed, 13 Dec 2023 16:10:25 +0800 Subject: [PATCH] sessionctx: change @@tidb_enable_gogc_tuner default value to 0 --- pkg/sessionctx/variable/tidb_vars.go | 2 +- pkg/sessionctx/variable/varsutil_test.go | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/sessionctx/variable/tidb_vars.go b/pkg/sessionctx/variable/tidb_vars.go index 2ef9ba709befb..0d43751c36c22 100644 --- a/pkg/sessionctx/variable/tidb_vars.go +++ b/pkg/sessionctx/variable/tidb_vars.go @@ -1375,7 +1375,7 @@ const ( DefTiDBServerMemoryLimitSessMinSize = 128 << 20 DefTiDBMergePartitionStatsConcurrency = 1 DefTiDBServerMemoryLimitGCTrigger = 0.7 - DefTiDBEnableGOGCTuner = true + DefTiDBEnableGOGCTuner = false // DefTiDBGOGCTunerThreshold is to limit TiDBGOGCTunerThreshold. DefTiDBGOGCTunerThreshold float64 = 0.6 DefTiDBGOGCMaxValue = 500 diff --git a/pkg/sessionctx/variable/varsutil_test.go b/pkg/sessionctx/variable/varsutil_test.go index 975cea729ac48..d8fa3d899e860 100644 --- a/pkg/sessionctx/variable/varsutil_test.go +++ b/pkg/sessionctx/variable/varsutil_test.go @@ -25,6 +25,7 @@ import ( "github.com/pingcap/tidb/pkg/kv" "github.com/pingcap/tidb/pkg/parser/mysql" "github.com/pingcap/tidb/pkg/parser/terror" + "github.com/pingcap/tidb/pkg/util/gctuner" "github.com/stretchr/testify/require" ) @@ -92,6 +93,7 @@ func TestNewSessionVars(t *testing.T) { require.Equal(t, DefTiDBAnalyzeVersion, vars.AnalyzeVersion) require.Equal(t, DefCTEMaxRecursionDepth, vars.CTEMaxRecursionDepth) require.Equal(t, int64(DefTiDBTmpTableMaxSize), vars.TMPTableSize) + require.Equal(t, DefTiDBEnableGOGCTuner, gctuner.EnableGOGCTuner.Load()) assertFieldsGreaterThanZero(t, reflect.ValueOf(vars.MemQuota)) assertFieldsGreaterThanZero(t, reflect.ValueOf(vars.BatchSize))