From 7ce083d7be640e3415aa3a81cf04353b79e029a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=B1=B1=E5=B2=9A?= <36239017+YuJuncen@users.noreply.github.com> Date: Wed, 26 Apr 2023 16:51:18 +0800 Subject: [PATCH] Revert "restore: split between tables (#42972)" This reverts commit 36c59c756208621d650140ea1cd32a7a94c42364. --- br/pkg/restore/split.go | 5 ----- br/pkg/restore/split_test.go | 8 +++----- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/br/pkg/restore/split.go b/br/pkg/restore/split.go index 9ed66e2bed43a..e218313f2212f 100644 --- a/br/pkg/restore/split.go +++ b/br/pkg/restore/split.go @@ -385,11 +385,6 @@ func (rs *RegionSplitter) ScatterRegions(ctx context.Context, newRegions []*spli func getSplitKeys(rewriteRules *RewriteRules, ranges []rtree.Range, regions []*split.RegionInfo, isRawKv bool) map[uint64][][]byte { splitKeyMap := make(map[uint64][][]byte) checkKeys := make([][]byte, 0) - if rewriteRules != nil && len(rewriteRules.NewKeyspace) == 0 { - for _, rule := range rewriteRules.Data { - checkKeys = append(checkKeys, rule.NewKeyPrefix) - } - } for _, rg := range ranges { checkKeys = append(checkKeys, rg.EndKey) } diff --git a/br/pkg/restore/split_test.go b/br/pkg/restore/split_test.go index 3bf6211c61f5f..de35cc3ab4c3c 100644 --- a/br/pkg/restore/split_test.go +++ b/br/pkg/restore/split_test.go @@ -479,12 +479,10 @@ func initRewriteRules() *restore.RewriteRules { // expected regions after split: // -// [aa, aay), [aay, bba), [bba, bbf), [bbf, bbh), [bbh, bbj), -// [bbj, cca), [cca, xx), [xx, xxe), [xxe, xxz), [xxz, ) -// -// Please note that "aa" has been rewritten to "xx", so the "bb" rewrite rule split point won't be included. +// [, aay), [aay, bba), [bba, bbf), [bbf, bbh), [bbh, bbj), +// [bbj, cca), [cca, xxe), [xxe, xxz), [xxz, ) func validateRegions(regions map[uint64]*split.RegionInfo) bool { - keys := [...]string{"", "aay", "bba", "bbf", "bbh", "bbj", "cca", "xx", "xxe", "xxz", ""} + keys := [...]string{"", "aay", "bba", "bbf", "bbh", "bbj", "cca", "xxe", "xxz", ""} return validateRegionsExt(regions, keys[:], false) }