From d97ac82ea7e52c976b85b874dcc34e04c5a698cb Mon Sep 17 00:00:00 2001
From: cbcwestwolf <1004626265@qq.com>
Date: Wed, 21 Dec 2022 14:55:40 +0800
Subject: [PATCH] sysvar: allow modifying 'tidb_allow_remove_auto_inc' when SEM
 is ON

---
 sessionctx/sessionstates/session_states_test.go | 2 +-
 util/sem/sem.go                                 | 1 -
 util/sem/sem_test.go                            | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/sessionctx/sessionstates/session_states_test.go b/sessionctx/sessionstates/session_states_test.go
index 5910d6b18e071..1eef55ed20bcf 100644
--- a/sessionctx/sessionstates/session_states_test.go
+++ b/sessionctx/sessionstates/session_states_test.go
@@ -133,7 +133,7 @@ func TestSystemVars(t *testing.T) {
 		{
 			// sem invisible variable
 			inSessionStates: false,
-			varName:         variable.TiDBAllowRemoveAutoInc,
+			varName:         variable.TiDBConfig,
 		},
 		{
 			// noop variables
diff --git a/util/sem/sem.go b/util/sem/sem.go
index 161334c880a4a..e2364893b05b2 100644
--- a/util/sem/sem.go
+++ b/util/sem/sem.go
@@ -136,7 +136,6 @@ func IsInvisibleStatusVar(varName string) bool {
 func IsInvisibleSysVar(varNameInLower string) bool {
 	switch varNameInLower {
 	case variable.TiDBDDLSlowOprThreshold, // ddl_slow_threshold
-		variable.TiDBAllowRemoveAutoInc,
 		variable.TiDBCheckMb4ValueInUTF8,
 		variable.TiDBConfig,
 		variable.TiDBEnableSlowLog,
diff --git a/util/sem/sem_test.go b/util/sem/sem_test.go
index cb0c47ad9225d..d19c2af27adcb 100644
--- a/util/sem/sem_test.go
+++ b/util/sem/sem_test.go
@@ -81,8 +81,8 @@ func TestIsInvisibleSysVar(t *testing.T) {
 
 	assert.False(IsInvisibleSysVar(variable.Hostname))                   // changes the value to default, but is not invisible
 	assert.False(IsInvisibleSysVar(variable.TiDBEnableEnhancedSecurity)) // should be able to see the mode is on.
+	assert.False(IsInvisibleSysVar(variable.TiDBAllowRemoveAutoInc))
 
-	assert.True(IsInvisibleSysVar(variable.TiDBAllowRemoveAutoInc))
 	assert.True(IsInvisibleSysVar(variable.TiDBCheckMb4ValueInUTF8))
 	assert.True(IsInvisibleSysVar(variable.TiDBConfig))
 	assert.True(IsInvisibleSysVar(variable.TiDBEnableSlowLog))