Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: avoid slicesgrow in the buildDataSource #58853

Merged
merged 3 commits into from
Jan 21, 2025
Merged

planner: avoid slicesgrow in the buildDataSource #58853

merged 3 commits into from
Jan 21, 2025

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 10, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58842

Problem Summary:

What changed and how does it work?

tidb/pkg/planner/core/logical_plan_builder.go

Lines 4648 to 4658 in cd9d3c0

extraCol := ds.NewExtraHandleSchemaCol()
handleCols = util.NewIntHandleCols(extraCol)
ds.Columns = append(ds.Columns, model.NewExtraHandleColInfo())
schema.Append(extraCol)
names = append(names, &types.FieldName{
DBName: dbName,
TblName: tableInfo.Name,
ColName: model.ExtraHandleName,
OrigColName: model.ExtraHandleName,
})
ds.TblCols = append(ds.TblCols, extraCol)

here is the root causion of the slices grow. so we should add 1 to the capacity of column

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
planner: avoid slicesgrow in the buildDataSource
cd9d3c0 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/planner SIG: Planner and removed do-not-merge/needs-tests-checked labels Jan 10, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.4543%. Comparing base (d9dc3f4) to head (f6dc16a).
Report is 66 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58853        +/-   ##
================================================
+ Coverage   73.1123%   75.4543%   +2.3419%     
================================================
  Files          1677       1731        +54     
  Lines        463901     483890     +19989     
================================================
+ Hits         339169     365116     +25947     
+ Misses       103885      96503      -7382     
- Partials      20847      22271      +1424
Flag Coverage Δ
integration 48.8076% <100.0000%> (?)
unit 72.9691% <100.0000%> (+0.6700%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.3315% <ø> (+15.6015%) ⬆️

@hawkingrei
remove rules
051c384 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
remove rules
f6dc16a 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 21, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 21, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-21 05:37:18.681512863 +0000 UTC m=+159166.012432261: ☑️ agreed by winoros.
  • 2025-01-21 06:13:51.960339174 +0000 UTC m=+161359.291258577: ☑️ agreed by AilinKid.

@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 448b92a into pingcap:master Jan 21, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove gowslices in the (*PlanBuilder).buildDataSource
3 participants
@hawkingrei @winoros @AilinKid