lightning should cache the result of columnAPI.Cols()
to improve performance
#56705
Labels
affects-6.5
affects-7.1
affects-7.5
affects-8.1
component/lightning
This issue is related to Lightning of TiDB.
severity/moderate
type/bug
The issue is confirmed as a bug.
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
capture a CPU profile when lightning encodes KV
tidb/br/pkg/lightning/backend/kv/sql2kv.go
Lines 491 to 497 in ff2feb6
some implementations of
columnAPI.Cols()
just return the slice, like before #50062 or after #53798. The other will filter and clone the slice.2. What did you expect to see? (Required)
stable performance for different versions of lightning
3. What did you see instead (Required)
the duration doubles
4. What is your TiDB version? (Required)
at least v6.5.10
The text was updated successfully, but these errors were encountered: