Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using multiple queries, affected row metrics may be inaccurate. #55875

Closed
jackysp opened this issue Sep 5, 2024 · 0 comments · Fixed by #55877
Closed

When using multiple queries, affected row metrics may be inaccurate. #55875

jackysp opened this issue Sep 5, 2024 · 0 comments · Fixed by #55877
Labels
component/metrics severity/moderate type/bug The issue is confirmed as a bug.

Comments

@jackysp
Copy link
Member

jackysp commented Sep 5, 2024 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

image

Affected rows only records the last SQL result, using multi-query will miss some. This can be seen in a workload where an insert writes one row at a time - affected rows does not match QPS.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

fef43c5
@jackysp jackysp added the type/bug The issue is confirmed as a bug. label Sep 5, 2024
@jackysp jackysp changed the title 使用 multi-query 的时候 affected rows metrics 不准确 When using multiple queries, affected row metrics may be inaccurate. Sep 5, 2024
@jackysp jackysp mentioned this issue Sep 5, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 2a86d34 Sep 10, 2024
Benjamin2037 pushed a commit to Benjamin2037/tidb that referenced this issue Sep 11, 2024
@jackysp @Benjamin2037
*: fix affected rows metrics to make it compatiable with multi-queries (
f4cdd07 
pingcap#55877)

close pingcap#55875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/metrics severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: fix affected rows metrics to make it compatiable with multi-queries jackysp/tidb
2 participants
@jackysp @jebter