Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix affected rows metrics to make it compatiable with multi-queries #55877

Merged
merged 4 commits into from
Sep 10, 2024
Merged

*: fix affected rows metrics to make it compatiable with multi-queries #55877

merged 4 commits into from
Sep 10, 2024

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Sep 5, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #55875

Problem Summary:

What changed and how does it work?

Set it in executor.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. start a cluster
  2. use multi-queries to insert data, e.g. insert; insert; insert;
  3. compare QPS(insert) and Affected Rows(insert)

This PR:
image

Master:
image

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@jackysp
*: fix affected rows metrics to make it compatiable with multi-queries
5459652 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@jackysp
tiny change
92f5bb8 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.2662%. Comparing base (fef43c5) to head (62c3781).
Report is 30 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #55877         +/-   ##
=================================================
- Coverage   72.8403%   57.2662%   -15.5741%     
=================================================
  Files          1599       1730        +131     
  Lines        444670     633249     +188579     
=================================================
+ Hits         323899     362638      +38739     
- Misses       100835     246815     +145980     
- Partials      19936      23796       +3860
Flag Coverage Δ
integration 38.8050% <100.0000%> (?)
unit 73.2019% <100.0000%> (+1.2397%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.8248% <ø> (+7.0515%) ⬆️

@jackysp
add comments
4c50fec 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@jackysp
add comments
62c3781 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@jackysp jackysp requested a review from bb7133 September 9, 2024 08:56
bb7133
bb7133 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 10, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-09 22:47:51.081829061 +0000 UTC m=+310140.822253001: ☑️ agreed by bb7133.
  • 2024-09-10 01:36:11.675287266 +0000 UTC m=+320241.415711205: ☑️ agreed by zyguan.

@zyguan
Copy link
Contributor

zyguan commented Sep 10, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 2a86d34 into pingcap:master Sep 10, 2024
23 checks passed
Benjamin2037 pushed a commit to Benjamin2037/tidb that referenced this pull request Sep 11, 2024
@jackysp @Benjamin2037
*: fix affected rows metrics to make it compatiable with multi-queries (
f4cdd07 
pingcap#55877)

close pingcap#55875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@zyguan zyguan zyguan approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
approved component/metrics lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using multiple queries, affected row metrics may be inaccurate.
3 participants
@jackysp @zyguan @bb7133