Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import into job finished but no data exists when injecting one of tidb failure for 2mins #46951

Closed
Lily2025 opened this issue Sep 13, 2023 · 3 comments
Assignees
Labels
component/disttask distributed execute framework of tidb feature/developing the related feature is in development severity/major type/bug The issue is confirmed as a bug.

Comments

@Lily2025
Copy link

Lily2025 commented Sep 13, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

1、import into user_data1 from 's3://brie/mvindex-10000000-csv/test.user_data1.*.csv?access-key=minioadmin&secret-access-key=minioadmin&endpoint=http://minio.pingcap.net:9001&force-path-style=true/' WITH skip_rows=1
2、 injecting one of tidb failure for 2mins

2. What did you expect to see? (Required)

import into job finished and checksum is correct

3. What did you see instead (Required)

cCrc32Checksum is 0, expected cCrc32Checksum is 3417923749

4. What is your TiDB version? (Required)

./tidb-server -V
Release Version: v7.4.0-alpha
Edition: Community
Git Commit Hash: 8f8c433
Git Branch: heads/refs/tags/v7.4.0-alpha
UTC Build Time: 2023-09-13 06:50:51
GoVersion: go1.21.1
Race Enabled: false
Check Table Before Drop: false
Store: unistore

@Lily2025 Lily2025 added the type/bug The issue is confirmed as a bug. label Sep 13, 2023
@Lily2025
Copy link
Author

/assign D3Hunter

@Lily2025 Lily2025 changed the title import into job finished but no data exist when injecting one of tidb failure for 2mins import into job finished but no data exists when injecting one of tidb failure for 2mins Sep 13, 2023
@D3Hunter
Copy link
Contributor

D3Hunter commented Sep 13, 2023

  • during subtask running, tidb owner quite for a while, the subtask is marked as failed with cancelled error(guess from log), and dispatcher exit
  • dispatcher restart, it sees the task as running, but it don't query failed subtask, so it think prev stage is finished and go into next stage directly
    cnt, err := d.taskMgr.GetSubtaskInStatesCnt(d.Task.ID, proto.TaskStatePending, proto.TaskStateRunning)
    if err != nil {
    logutil.Logger(d.logCtx).Warn("check task failed", zap.Error(err))
    return err
    }
    if cnt == 0 {

@jebter jebter added severity/critical component/lightning This issue is related to Lightning of TiDB. feature/developing the related feature is in development labels Sep 14, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Sep 14, 2023
@D3Hunter D3Hunter added severity/major and removed severity/critical may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Sep 15, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Sep 15, 2023
@D3Hunter D3Hunter added component/ddl This issue is related to DDL of TiDB. component/disttask distributed execute framework of tidb and removed component/lightning This issue is related to Lightning of TiDB. labels Sep 15, 2023
@D3Hunter D3Hunter removed may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 component/ddl This issue is related to DDL of TiDB. labels Sep 15, 2023
@D3Hunter
Copy link
Contributor

fixed by #45623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/disttask distributed execute framework of tidb feature/developing the related feature is in development severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

3 participants