Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert SELECT .. LOCK IN SHARE MODE to SELECT .. FOR UPDATE #33244

Open
morgo opened this issue Mar 18, 2022 · 0 comments
Open

Convert SELECT .. LOCK IN SHARE MODE to SELECT .. FOR UPDATE #33244

morgo opened this issue Mar 18, 2022 · 0 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@morgo
Copy link
Contributor

morgo commented Mar 18, 2022

Enhancement

Shared locks are not supported in TiKV.

In #19383 a protection was added so that SELECT .. LOCK IN SHARE MODE is no longer a noop, since it is unsafe to do so.

This enhancement proposes that instead of a noop, it is instead converted to SELECT .. FOR UPDATE (either for all cases, or when a new setting is set.) This might improve compatibility for applications is exclusive locks is sufficient for compatibility.
@morgo morgo added the type/enhancement The issue or PR belongs to an enhancement. label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@morgo