Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not allow historical read in local temporary tables #25938

Closed
Tracked by #24169
djshow832 opened this issue Jul 5, 2021 · 5 comments · Fixed by #27363
Closed
Tracked by #24169

do not allow historical read in local temporary tables #25938

djshow832 opened this issue Jul 5, 2021 · 5 comments · Fixed by #27363
Assignees

Comments

@djshow832
Copy link
Contributor

No description provided.

@djshow832 djshow832 mentioned this issue Jul 5, 2021
89 tasks
@sylzd
Copy link
Contributor

sylzd commented Aug 7, 2021

/assign

@sylzd
Copy link
Contributor

sylzd commented Aug 18, 2021

It can be closed by #27270. @djshow832

details are as follows:
https://github.com/pingcap/tidb/pull/27270/files#diff-ff7af5dbd454cd98c804a32d8049cd73e476ad819042c63dbe690502f915afeeR8905

	for _, query := range queries {
		localSQL := genLocalTemporarySQL(query.sql)
		queries = append(queries, struct{ sql string }{sql: localSQL})
	}

and

	tk.MustExec("set @@tidb_snapshot=NOW(6)")
	for _, query := range queries {
		// Will success here for compatibility with some tools like dumping
		rs := tk.MustQuery(query.sql)
		rs.Check(testkit.Rows())
	}

@lcwangchao
Copy link
Collaborator

@sylzd I think we should forbid history read on local temporary table. This behavior is different from global temporary tables which need to be compatible with some tools like dumpling.

@sylzd
Copy link
Contributor

sylzd commented Aug 19, 2021

@sylzd I think we should forbid history read on local temporary table. This behavior is different from global temporary tables which need to be compatible with some tools like dumpling.

Got it~ local temporary tables do not need adapt to dumpling.

@sylzd
Copy link
Contributor

sylzd commented Aug 19, 2021

@sylzd I think we should forbid history read on local temporary table. This behavior is different from global temporary tables which need to be compatible with some tools like dumpling.

Got it~ local temporary tables do not need adapt to dumpling.

done with #27363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants