Skip to content

Commit e869935

Browse files
committed
simplify SetEnabled method
1 parent 113b86b commit e869935

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

util/stmtsummary/statement_summary.go

+8-9
Original file line numberDiff line numberDiff line change
@@ -235,23 +235,22 @@ func (ssMap *stmtSummaryByDigestMap) SetEnabled(enable string, inSession bool) {
235235
enable = ssMap.normalizeEnableValue(enable)
236236

237237
ssMap.enabledWrapper.Lock()
238-
needClear := false
239238
if inSession {
240239
ssMap.enabledWrapper.sessionEnabled = enable
241-
if ssMap.isSet(enable) {
242-
needClear = !ssMap.isEnabled(enable)
243-
} else {
244-
needClear = !ssMap.isEnabled(ssMap.enabledWrapper.globalEnabled)
245-
}
246240
} else {
247241
ssMap.enabledWrapper.globalEnabled = enable
248-
if !ssMap.isSet(ssMap.enabledWrapper.sessionEnabled) {
249-
needClear = !ssMap.isEnabled(enable)
250-
}
251242
}
243+
sessionEnabled := ssMap.enabledWrapper.sessionEnabled
244+
globalEnabled := ssMap.enabledWrapper.globalEnabled
252245
ssMap.enabledWrapper.Unlock()
253246

254247
// Clear all summaries once statement summary is disabled.
248+
var needClear bool
249+
if ssMap.isSet(sessionEnabled) {
250+
needClear = !ssMap.isEnabled(sessionEnabled)
251+
} else {
252+
needClear = !ssMap.isEnabled(globalEnabled)
253+
}
255254
if needClear {
256255
ssMap.Clear()
257256
}

0 commit comments

Comments
 (0)