From 8aa0c7f212391b3b566c451b9790678883f8139f Mon Sep 17 00:00:00 2001 From: tangenta Date: Tue, 13 Dec 2022 17:10:08 +0800 Subject: [PATCH] return the first error --- ddl/ingest/engine.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/ddl/ingest/engine.go b/ddl/ingest/engine.go index 5fe85e7263268..c7ed29a71d017 100644 --- a/ddl/ingest/engine.go +++ b/ddl/ingest/engine.go @@ -193,14 +193,19 @@ func (ei *engineInfo) newWriterContext(workerID int) (*WriterContext, error) { } func (ei *engineInfo) closeWriters() error { - var err error + var firstErr error for wid := range ei.writerCache.Keys() { if w, ok := ei.writerCache.Load(wid); ok { - _, err = w.Close(ei.ctx) + _, err := w.Close(ei.ctx) + if err != nil { + if firstErr == nil { + firstErr = err + } + } } ei.writerCache.Delete(wid) } - return err + return firstErr } // WriteRow Write one row into local writer buffer.