executor: address comments

zimulala · zimulala · commit 361a41df68e7 · 2018-10-25T13:32:01.000+08:00
diff --git a/executor/ddl.go b/executor/ddl.go
@@ -68,8 +68,8 @@ func (e *DDLExec) Next(ctx context.Context, chk *chunk.Chunk) (err error) {
 	}
 	e.done = true
 
-	// For every DDL, we must commit current transaction.
-	if err := e.ctx.NewTxn(); err != nil {
+	// For each DDL, we should commit the previous transaction and create a new transaction.
+	if err = e.ctx.NewTxn(); err != nil {
 		return errors.Trace(err)
 	}
 	defer func() { e.ctx.GetSessionVars().StmtCtx.IsDDLJobInQueue = false }()

Original file line number	Diff line number	Diff line change
`@@ -68,8 +68,8 @@ func (e DDLExec) Next(ctx context.Context, chk chunk.Chunk) (err error) {`
`68`	`68`	`}`
`69`	`69`	`e.done = true`
`70`	`70`
`71`		`- // For every DDL, we must commit current transaction.`
`72`		`- if err := e.ctx.NewTxn(); err != nil {`
	`71`	`+ // For each DDL, we should commit the previous transaction and create a new transaction.`
	`72`	`+ if err = e.ctx.NewTxn(); err != nil {`
`73`	`73`	`return errors.Trace(err)`
`74`	`74`	`}`
`75`	`75`	`defer func() { e.ctx.GetSessionVars().StmtCtx.IsDDLJobInQueue = false }()`