Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP: Enhance tidbclusterautoscaler output information in kubectl get #1820

Closed
Yisaer opened this issue Feb 28, 2020 · 4 comments
Closed

UCP: Enhance tidbclusterautoscaler output information in kubectl get #1820

Yisaer opened this issue Feb 28, 2020 · 4 comments
Labels
challenge-program-2 difficulty/easy good first issue Good for newcomers status/help-wanted Extra attention is needed

Comments

@Yisaer
Copy link
Contributor

Yisaer commented Feb 28, 2020 •
edited by cofyc
Loading

Description

Currently, when we execute kubectl get ta, we only see basic information about the tidbclusterautoscaler.

$ kubectl get ta   
NAME     AGE
scaler   128m

We need to show more useful information, for example:

$ kubectl get ta   
NAME     AGE  TiKV  MaxReplicas   MinReplicas  TiDB  MaxReplicas   MinReplicas
scaler   128m  3         5            3          2       3              2

We can configure some additional print columns in our CRD manifest yaml. There are some examples in pkg/util/crdutil.go. You can run hack/update-crd-groups.sh to update our CRD manifest yaml file.

Score

  • 50

Mentor(s)

Contact the mentors: #tidb-challenge-program channel in TiDB-Operator Community Slack Workspace

Recommended Skills

  • Golang
  • Kubernetes

Learning Materials
@Yisaer Yisaer added area/auto-scaling related to auto-scaling good first issue Good for newcomers status/help-wanted Extra attention is needed labels Feb 28, 2020
@Yisaer Yisaer mentioned this issue Feb 28, 2020
Open
4 tasks
@cofyc cofyc added challenge-program-2 difficulty/easy and removed area/auto-scaling related to auto-scaling good first issue Good for newcomers status/help-wanted Extra attention is needed labels Mar 11, 2020
@cofyc cofyc changed the title Enhance tidbclusterautoscaler information by kubectl get UCP: Enhance tidbclusterautoscaler output information in kubectl get Mar 11, 2020
@cofyc cofyc added good first issue Good for newcomers status/help-wanted Extra attention is needed labels Mar 11, 2020
@shonge
Copy link
Member

shonge commented Mar 16, 2020

/pick-up-challenge

@shonge
Copy link
Member

shonge commented Mar 16, 2020 

[root@localhost basic]# kn t1 get ta
NAME       TIDB-MAXREPLICAS   TIDB-MINREPLICAS   TIKV-MAXREPLICAS   TIKV-MINREPLICAS
basic-autoscaler   5                  2                  5                  2

@shonge shonge mentioned this issue Mar 16, 2020
Merged
@sre-bot sre-bot mentioned this issue Mar 25, 2020
Merged
@shonge
Copy link
Member

shonge commented Apr 15, 2020

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

@shonge pick up issue success

@sre-bot sre-bot mentioned this issue Apr 15, 2020
Closed
@Yisaer Yisaer closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
challenge-program-2 difficulty/easy good first issue Good for newcomers status/help-wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cofyc @Yisaer @shonge @sre-bot