*: Make unconvert linter happy and locking golangci-lint version

.golangci.yml

@@ -0,0 +1,3 @@
+linters:
+  enable:
+    - unconvert

Makefile

@@ -215,9 +215,9 @@ tools/bin/errdoc-gen: tools/check/go.mod
 	cd tools/check; test -e ../bin/errdoc-gen || \
 	$(GO) build -o ../bin/errdoc-gen github.com/pingcap/errors/errdoc-gen
 
-tools/bin/golangci-lint: tools/check/go.mod
+tools/bin/golangci-lint:
 	cd tools/check; test -e ../bin/golangci-lint || \
-	$(GO) build -o ../bin/golangci-lint github.com/golangci/golangci-lint/cmd/golangci-lint
+	curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b ../bin v1.30.0
 
 failpoint-enable: check_failpoint_ctl
 	$(FAILPOINT_ENABLE)

cdc/model/changefeed.go

@@ -170,7 +170,7 @@ func (info *ChangeFeedInfo) Unmarshal(data []byte) error {
 			return errors.Annotatef(
 				cerror.WrapError(cerror.ErrMarshalFailed, err), "Marshal data: %v", data)
 		}
-		info.Opts[mark.OptCyclicConfig] = string(cyclicCfg)
+		info.Opts[mark.OptCyclicConfig] = cyclicCfg
 	}
 	return nil
 }

cdc/model/sink.go

@@ -314,19 +314,19 @@ func ColumnValueString(c interface{}) string {
 	case int32:
 		data = strconv.FormatInt(int64(v), 10)
 	case int64:
-		data = strconv.FormatInt(int64(v), 10)
+		data = strconv.FormatInt(v, 10)
 	case uint8:
 		data = strconv.FormatUint(uint64(v), 10)
 	case uint16:
 		data = strconv.FormatUint(uint64(v), 10)
 	case uint32:
 		data = strconv.FormatUint(uint64(v), 10)
 	case uint64:
-		data = strconv.FormatUint(uint64(v), 10)
+		data = strconv.FormatUint(v, 10)
 	case float32:
 		data = strconv.FormatFloat(float64(v), 'f', -1, 32)
 	case float64:
-		data = strconv.FormatFloat(float64(v), 'f', -1, 64)
+		data = strconv.FormatFloat(v, 'f', -1, 64)
 	case string:
 		data = v
 	case []byte:

cdc/owner.go

@@ -148,7 +148,7 @@ const (
 	// CDCServiceSafePointID is the ID of CDC service in pd.UpdateServiceGCSafePoint.
 	CDCServiceSafePointID = "ticdc"
 	// GCSafepointUpdateInterval is the minimual interval that CDC can update gc safepoint
-	GCSafepointUpdateInterval = time.Duration(2 * time.Second)
+	GCSafepointUpdateInterval = 2 * time.Second
 	// MinGCSafePointCacheUpdateInterval is the interval that update minGCSafePointCache
 	MinGCSafePointCacheUpdateInterval = time.Second * 2
 )

cdc/processor/processor.go

@@ -288,7 +288,7 @@ func (p *processor) lazyInitImpl(ctx cdcContext.Context) error {
 		if err != nil {
 			return errors.Trace(err)
 		}
-		opts[mark.OptCyclicConfig] = string(cyclicCfg)
+		opts[mark.OptCyclicConfig] = cyclicCfg
 	}
 	opts[sink.OptChangefeedID] = p.changefeed.ID
 	opts[sink.OptCaptureAddr] = ctx.GlobalVars().CaptureInfo.AdvertiseAddr

cdc/server.go

@@ -271,7 +271,7 @@ func (s *Server) etcdHealthChecker(ctx context.Context) error {
 		case <-ticker.C:
 			for _, pdEndpoint := range s.pdEndpoints {
 				start := time.Now()
-				ctx, cancel := context.WithTimeout(ctx, time.Duration(time.Second*10))
+				ctx, cancel := context.WithTimeout(ctx, time.Second*10)
 				req, err := http.NewRequestWithContext(
 					ctx, http.MethodGet, fmt.Sprintf("%s/health", pdEndpoint), nil)
 				if err != nil {

cdc/sink/codec/craft/model.go

@@ -71,7 +71,7 @@ func (d *termDictionary) encodeNullable(s *string) int64 {
 	if s == nil {
 		return nullInt64
 	}
-	return int64(d.encode(*s))
+	return d.encode(*s)
 }
 
 func (d *termDictionary) encode(s string) int64 {
@@ -424,7 +424,7 @@ func newRowChangedMessage(allocator *SliceAllocator, ev *model.RowChangedEvent)
 		groups[idx] = group
 		estimatedSize += size
 	}
-	return estimatedSize, rowChangedEvent(groups)
+	return estimatedSize, groups
 }
 
 // RowChangedEventBuffer is a buffer to save row changed events in batch

cmd/util.go

@@ -252,9 +252,9 @@ func verifyTables(ctx context.Context, credential *security.Credential, cfg *con
 	}
 
 	for tID, tableName := range snap.CloneTables() {
-		tableInfo, exist := snap.TableByID(int64(tID))
+		tableInfo, exist := snap.TableByID(tID)
 		if !exist {
-			return nil, nil, errors.NotFoundf("table %d", int64(tID))
+			return nil, nil, errors.NotFoundf("table %d", tID)
 		}
 		if filter.ShouldIgnoreTable(tableName.Schema, tableName.Table) {
 			continue

tools/check/go.mod

@@ -3,7 +3,6 @@ module github.com/pingcap/tidb-cdc/_tools
 go 1.16
 
 require (
-	github.com/golangci/golangci-lint v1.33.0
 	github.com/mgechev/revive v1.0.2
 	github.com/pingcap/errors v0.11.5-0.20201126102027-b0a155152ca3
 	mvdan.cc/gofumpt v0.0.0-20201123090407-3077abae40c0