Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prepare_test_binaries target to Makefile for easier binary downloads #1075

Closed
wlwilliamx opened this issue Mar 11, 2025 · 0 comments · Fixed by #1076
Closed

Add prepare_test_binaries target to Makefile for easier binary downloads #1075

wlwilliamx opened this issue Mar 11, 2025 · 0 comments · Fixed by #1076
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@wlwilliamx
Copy link
Collaborator

wlwilliamx commented Mar 11, 2025

Currently, we manually run tests/scripts/download-integration-test-binaries.sh to download TiCDC-related binaries for integration testing. To simplify this process, we should add a prepare_test_binaries target in the Makefile, allowing users to run a single make command to download the required binaries.

Proposal

Add the following rule to the Makefile:

prepare_test_binaries:
	./scripts/download-integration-test-binaries.sh "$(branch)" "$(community)" "$(ver)" "$(os)" "$(arch)"

Usage

Users can run:

make prepare_test_binaries

If specific parameters are required, they can be provided as follows:

make prepare_test_binaries community=true ver=v8.0.0 os=linux arch=amd64

This will make it easier for developers and CI pipelines to retrieve the necessary binaries.

@wlwilliamx wlwilliamx self-assigned this Mar 11, 2025
@wlwilliamx wlwilliamx added the type/enhancement The issue or PR belongs to an enhancement. label Mar 11, 2025
@ti-chi-bot ti-chi-bot bot closed this as completed in d3ea643 Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant