Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: refine config clone (#3116) #3120

Merged
merged 3 commits into from
Nov 2, 2020
Merged

config: refine config clone (#3116) #3120

merged 3 commits into from
Nov 2, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3116 to release-4.0

What problem does this PR solve?

  • The config of store-balance-rate and trace-region-flow will be lost during Clone.

What is changed and how it works?

  • config: refine config clone
  • server: clone config in GetConfig

Check List

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the bug that trace-region-flow will be accidentally changed to false.

@HunDunDM @ti-srebot
cherry pick tikv#3116 to release-4.0
54c57cd 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 29, 2020
Merged
@ti-srebot ti-srebot added component/config Configuration logic. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/cherry-pick labels Oct 29, 2020
@ti-srebot ti-srebot added this to the v4.0.8 milestone Oct 29, 2020
@HunDunDM
fix
6aa7876 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM
fix
1e84aa1 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM
Copy link
Member

/run-all-tests

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT3 The PR has already had 3 LGTM. labels Oct 29, 2020
Yisaer
Yisaer approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 29, 2020
@HunDunDM HunDunDM modified the milestones: v4.0.8, v4.0.9 Oct 29, 2020
@nolouch nolouch added the status/wait-launch-window Wait for the release launch window. label Oct 30, 2020
@HunDunDM
Copy link
Member

HunDunDM commented Nov 2, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit f9ce6a0 into tikv:release-4.0 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch Awaiting requested review from nolouch

@rleungx rleungx Awaiting requested review from rleungx

Assignees

@HunDunDM HunDunDM

Labels
component/config Configuration logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/wait-launch-window Wait for the release launch window. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v4.0.9
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @HunDunDM @Yisaer @lhy1024 @nolouch