Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: update to v2020.09.08.1 and add enable-experimental config (#2926) #2928

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2926 to release-4.0


What problem does this PR solve?

  • dashboard: update to v2020.09.08.1
  • dashboard: add enable-experimental config

Check List

Tests

  • Unit test

Code changes

  • Has configuration change

Related changes

Release note

  • dashboard: update to v2020.09.08.1
  • dashboard: add enable-experimental config

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT3 The PR has already had 3 LGTM. labels Sep 8, 2020
@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 8, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 8, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 8, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 8, 2020

/run-integration-lightning-test

1 similar comment
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 8, 2020

/run-integration-lightning-test

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #2928 into release-4.0 will increase coverage by 0.16%.
The diff coverage is 66.92%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2928      +/-   ##
===============================================
+ Coverage        77.16%   77.33%   +0.16%     
===============================================
  Files              204      209       +5     
  Lines            21940    22866     +926     
===============================================
+ Hits             16931    17684     +753     
- Misses            3724     3840     +116     
- Partials          1285     1342      +57     
Impacted Files Coverage Δ
client/metrics.go 100.00% <ø> (ø)
pkg/apiutil/apiutil.go 67.34% <ø> (ø)
pkg/cache/cache.go 0.00% <ø> (ø)
pkg/cache/fifo.go 100.00% <ø> (ø)
pkg/cache/lru.go 80.35% <ø> (ø)
pkg/cache/two_queue.go 66.66% <ø> (ø)
pkg/codec/codec.go 78.57% <ø> (ø)
pkg/component/manager.go 81.01% <ø> (ø)
pkg/dashboard/adapter/redirector.go 94.23% <ø> (ø)
pkg/dashboard/keyvisual/input/core.go 33.33% <ø> (ø)
... and 208 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9feb83...46d74e9. Read the comment docs.

@lhy1024 lhy1024 merged commit aeaac24 into tikv:release-4.0 Sep 8, 2020
@HunDunDM HunDunDM deleted the release-4.0-a5b90288bf10 branch September 8, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/visualization Visualization. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants